Read Workbench-managed Databricks credentials from databricks.cfg
#805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously odbc::databricks() used .rs.api.getDatabricksToken() to check for Workbench-managed credentials, which only works inside the RStudio console. With this commit we look at the generated config file instead, as we do for Snowflake in odbc::snowflake(). This gives background jobs and, importantly, the Quarto and RMarkdown rendering panes access to these credentials as well. Unit tests are included. Closes #803. Signed-off-by: Aaron Jacobs <aaron.jacobs@rstudio.com>
atheriel
force-pushed
the
aj-db-workbench-credentials-from-file
branch
from
bed68e1 to
ee39a4b
Compare
hadley
approved these changes
May 17, 2024
simonpcouch
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
odbc::databricks()used.rs.api.getDatabricksToken()to check for Workbench-managed credentials, which only works inside the RStudio console. With this commit we look at the generated config file instead, as we do for Snowflake inodbc::snowflake(). This gives background jobs and, importantly, the Quarto and RMarkdown rendering panes access to these credentials as well.Unit tests are included.
Closes #803.