Permit retrieval of unicode data in VAR/CHAR columns #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
approved these changes
Mar 26, 2023
| @@ -102,6 +102,16 @@ | |||
| #endif | |||
| #endif | |||
|
|
|||
| #if defined(NANODBC_OVERALLOCATE_CHAR) | |||
There was a problem hiding this comment.
Are we diverging from nanodbc here, or did you get this merged upstream?
There was a problem hiding this comment.
Yep, merged upstream.
There was a problem hiding this comment.
Nice, thanks for all your work on this!
This was referenced Apr 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #369 #437 #489 #524
There are some more details about the issue here
The short summary is: This work helps us better support
This comes at the cost of larger memory allocations. However these memory allocations are transient ( created/destroyed with each query ), and do not scale, for example, with the size of the data set ( number of rows ). From that perspective, I expect marginal impact - but worth keeping an eye out.