Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laplace Transform drops unary minus #64

Open
Quiigi opened this issue Mar 22, 2022 · 4 comments
Open

Laplace Transform drops unary minus #64

Quiigi opened this issue Mar 22, 2022 · 4 comments

Comments

@Quiigi
Copy link

Quiigi commented Mar 22, 2022

The file yacas/transforms.rep/code.ys starts like this:

10 # LaplaceTransform(_var1,_var2, _expr )      <-- LapTran(var1,var2,expr);

// Linearity properties 
10 # LapTran(_var1,_var2,_x + _y)               <-- LapTran(var1,var2,x) + LapTran(var1,var2,y);
10 # LapTran(_var1,_var2,_x - _y)               <-- LapTran(var1,var2,x) - LapTran(var1,var2,y);
10 # LapTran(_var1,_var2,    - _y)              <-- LapTran(var1,var2,y);

I believe that last rule, on line 6, is incorrect. To correctly express linearity, it should preserve the sign, i.e.,

10 # LapTran(_var1,_var2,    - _y)              <-- - LapTran(var1,var2,y);

Likely that issue exists upstream in yacas itself, and is not specific to this R interface.

@mikldk
Copy link
Collaborator

mikldk commented Mar 23, 2022

@grzegorzmazur Can you help here? Should this issue be created at https://github.com/grzegorzmazur/yacas/issues instead?

@grzegorzmazur
Copy link
Contributor

Yes, please.

@mikldk
Copy link
Collaborator

mikldk commented Mar 23, 2022

@Quiigi Can I please ask you to open this issue in the yacas repo ^^?

grzegorzmazur added a commit to grzegorzmazur/yacas that referenced this issue Mar 24, 2022
@grzegorzmazur
Copy link
Contributor

OK, fixed (but for now only in upstream yacas). Thank you for finding and reporting the issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants