Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keybinds #91

Merged
merged 3 commits into from
Feb 17, 2025
Merged

keybinds #91

merged 3 commits into from
Feb 17, 2025

Conversation

qxb3
Copy link
Owner

@qxb3 qxb3 commented Feb 16, 2025

added:

  • action-secondary on button. (exec will not be triggered on this).
  • key modifiers: shift ctrl alt super hyper meta.
    Examples: ctrl+c alt+ctrl+c esc;q;ctrl+c

#89 #88

@qxb3 qxb3 added the enhancement New feature or request label Feb 16, 2025
@qxb3 qxb3 self-assigned this Feb 16, 2025
This was linked to issues Feb 16, 2025
@qxb3
Copy link
Owner Author

qxb3 commented Feb 16, 2025

@danielwerg can you test it out if u have time?

@danielwerg
Copy link
Contributor

action-secondary works great.

"q;Q;ctrl+c": "quit()":

thread 'main' panicked at src/config/keybind.rs:68:45:
internal error: entered unreachable code

but that seems expected? https://github.com/qxb3/fum/blob/keybinds/src/config/keybind.rs#L68

@qxb3
Copy link
Owner Author

qxb3 commented Feb 16, 2025

@danielwerg should be now fixed.

@danielwerg
Copy link
Contributor

Yep, fixed! Could you update my lowfi clone rice by adding ctrl+c for quit() once this is merged?

@qxb3
Copy link
Owner Author

qxb3 commented Feb 16, 2025

sure! but not on merge tho, but on weekly new release.

@qxb3 qxb3 changed the base branch from main to dev February 17, 2025 02:49
@qxb3 qxb3 merged commit 5dd4fd3 into dev Feb 17, 2025
@qxb3 qxb3 deleted the keybinds branch February 17, 2025 02:49
qxb3 added a commit that referenced this pull request Feb 17, 2025
* action-secondary

* keybind modifier

* fix keybind modifier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mouse keybinds Keybind modifiers
2 participants