Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make volume an optional field #106

Merged
merged 1 commit into from
Feb 28, 2025
Merged

fix: make volume an optional field #106

merged 1 commit into from
Feb 28, 2025

Conversation

rubyowo
Copy link
Contributor

@rubyowo rubyowo commented Feb 27, 2025

Closes #105

@danielwerg
Copy link
Contributor

This reminded me that it would be great to have conditional UI elements. For configs like this:

"players": [],
"use_active_player": true,
// ...

@qxb3
Copy link
Owner

qxb3 commented Feb 28, 2025

thanks!

@qxb3 qxb3 merged commit 5d87b55 into qxb3:main Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firefox media is missing metadata but controls work
3 participants