This repository was archived by the owner on Jun 28, 2021. It is now read-only.
Added Nafees font for Urdu and Punjabi translation #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to: http://staging.quran.com:32857 |
naveed-ahmad
changed the title
|
@naveed-ahmad what are your thoughts on the font size? Looks pretty small when using the new font. |
|
@sabeurthabti default fonts actually looks small to me :) any average Urdu reader can read the new 'Nafees' pretty easily. Bottom line, font size looks good to me. Urdu is my mother tongue btw. |
|
LGTM |
|
this is awesome!! thank you thank you thank you @naveed-ahmad |
|
@ahmedre we may need to add these font files to the CDN please! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to configure fonts for translation. This PR is adding fonts for Urdu, and Punjabi language for now. But it has opened the door to add fonts for any language :)
Default font:
New Nafees font:
