Unitary FirewallRule reconciliation #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klibr007
force-pushed
the
firewallcontroller-unitary-reconcilitaion
branch
2 times, most recently
from
f447841 to
93e0264
Compare
klibr007
force-pushed
the
firewallcontroller-unitary-reconcilitaion
branch
3 times, most recently
from
eecd193 to
98d6718
Compare
klibr007
force-pushed
the
firewallcontroller-unitary-reconcilitaion
branch
from
98d6718 to
7840d11
Compare
antonincms
reviewed
Feb 11, 2025
There was a problem hiding this comment.
Hello @klibr007, thanks for the PR, here is a first review.
antonincms
reviewed
Feb 12, 2025
vincentmrg
reviewed
Feb 12, 2025
antonincms
reviewed
Feb 12, 2025
vincentmrg
reviewed
Feb 12, 2025
klibr007
force-pushed
the
firewallcontroller-unitary-reconcilitaion
branch
from
cfa964c to
16b4934
Compare
delete securitygroup if removing last rule
klibr007
force-pushed
the
firewallcontroller-unitary-reconcilitaion
branch
from
16b4934 to
27d4bd4
Compare
antonincms
reviewed
Feb 13, 2025
antonincms
approved these changes
Feb 13, 2025
antonincms
changed the title
antonincms
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is to change the way reconciliation is done for firewallrule resources. The goal has been to reconcile only one firewallrule during the reconciliation of a firewallrule. So either we add the rule if it doesn't exist or we delete it if it has to.
What I have checked:
Security group creation
Network interface association
Adding one rule that doesn't exist
Adding 201 rules reconcilition is done unitary and there is one firewallrule pending
Deleting all firewallrule simultanously the security group is deleted and the firewallrule are removed during their reconciliation
Deleting firewallrules one by one, firewallrules are deleted one by one and the securitygroup is deleted during the reconciliation of the last firewallrule
Removing manually a rule from security group, if the firewallrule still exists il will be recreated
If a rule is added manually in the security group it will be removed