Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FastFieldRangeQuery, rename #2477

Merged
merged 2 commits into from
Aug 19, 2024
Merged

add FastFieldRangeQuery, rename #2477

merged 2 commits into from
Aug 19, 2024

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented Aug 16, 2024

add FastFieldRangeQuery
add reexport
rename module

preparation for support on string range queries in quickwit

@PSeitz PSeitz force-pushed the str_fast_field_range_query2 branch from 26a5a15 to 324d803 Compare August 16, 2024 13:04
Copy link
Contributor

@trinity-1686a trinity-1686a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FastFieldRangeWeight implements Query, imo that should be removed if we now have a proper Query type for that

@PSeitz
Copy link
Contributor Author

PSeitz commented Aug 17, 2024

FastFieldRangeWeight implements Query, imo that should be removed if we now have a proper Query type for that

The RangeWeight is still a valid export, which can be used in a custom Query

@trinity-1686a
Copy link
Contributor

i don't mean to remove FastFieldRangeWeight, but to remove impl Query for FastFieldRangeWeight

@PSeitz
Copy link
Contributor Author

PSeitz commented Aug 19, 2024

i don't mean to remove FastFieldRangeWeight, but to remove impl Query for FastFieldRangeWeight

Ah yes that makes sense

@PSeitz PSeitz merged commit c71ec80 into main Aug 19, 2024
4 checks passed
@PSeitz PSeitz deleted the str_fast_field_range_query2 branch August 19, 2024 07:02
philippemnoel pushed a commit to paradedb/tantivy that referenced this pull request Aug 31, 2024
* add FastFieldRangeQuery, rename

* remove Query impl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants