Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate sort by field type #2336

Merged
merged 2 commits into from
Apr 16, 2024
Merged

validate sort by field type #2336

merged 2 commits into from
Apr 16, 2024

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented Mar 29, 2024 •
edited
Loading

@PSeitz PSeitz requested a review from fulmicoton March 29, 2024 01:53
adamreichold
adamreichold reviewed Mar 29, 2024
View reviewed changes
@PSeitz @adamreichold
Update src/index/index.rs
a923304 
Co-authored-by: Adam Reichold <adamreichold@users.noreply.github.com>
@PSeitz PSeitz merged commit b257b96 into main Apr 16, 2024
4 checks passed
@PSeitz PSeitz deleted the sort_by_text branch April 16, 2024 02:42
philippemnoel pushed a commit to paradedb/tantivy that referenced this pull request Aug 31, 2024
@PSeitz @adamreichold @philippemnoel
validate sort by field type (quickwit-oss#2336)
e0b01bf 
* validate sort by field type

* Update src/index/index.rs

Co-authored-by: Adam Reichold <adamreichold@users.noreply.github.com>

---------

Co-authored-by: Adam Reichold <adamreichold@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamreichold adamreichold adamreichold left review comments

@fulmicoton fulmicoton fulmicoton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PSeitz @fulmicoton @adamreichold