Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend facet deserialization to handle owned in addition to borrowed strings. #1466

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Extend facet deserialization to handle owned in addition to borrowed strings. #1466

merged 1 commit into from
Aug 23, 2022

Conversation

adamreichold
Copy link
Collaborator

Noticed this when trying to deserialize Facet from URL query parameters. This also avoids the panic when deserializing (potentially untrusted) content.

fulmicoton
fulmicoton approved these changes Aug 23, 2022
View reviewed changes
Copy link
Collaborator

@fulmicoton fulmicoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Error handling is much better.

@fulmicoton fulmicoton merged commit df0ac9e into quickwit-oss:main Aug 23, 2022
This was referenced Jan 13, 2023
Closed
Closed
@PSeitz PSeitz mentioned this pull request Jan 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulmicoton fulmicoton fulmicoton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamreichold @fulmicoton