Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing parameter on relevant aggregations #1789

Closed
guilload opened this issue Jan 14, 2023 · 0 comments · Fixed by #2149
Closed

Add missing parameter on relevant aggregations #1789

guilload opened this issue Jan 14, 2023 · 0 comments · Fixed by #2149
Assignees
@PSeitz
Labels
high priority

Comments

@guilload
Copy link
Member

This value will be used for sparse fields and ignored otherwise.

Relevant aggs (non-exhaustive):
avg, stats, sum, ...
@PSeitz PSeitz mentioned this issue Jun 22, 2023
Closed
@PSeitz PSeitz mentioned this issue Jun 28, 2023
Merged
This was referenced Aug 18, 2023
Merged
Merged
PSeitz added a commit that referenced this issue Aug 25, 2023
@PSeitz
add missing parameter for stats,min,max,count,sum,avg
abfdefa 
add missing parameter for stats,min,max,count,sum,avg
closes #1913
partially #1789
PSeitz added a commit that referenced this issue Aug 25, 2023
@PSeitz
add missing parameter for stats,min,max,count,sum,avg
cb27d77 
add missing parameter for stats,min,max,count,sum,avg
closes #1913
partially #1789
PSeitz added a commit that referenced this issue Aug 28, 2023
@PSeitz @fulmicoton
add missing parameter for stats,min,max,count,sum,avg (#2151)
73cb717 
* add missing parameter for stats,min,max,count,sum,avg

add missing parameter for stats,min,max,count,sum,avg
closes #1913
partially #1789

* Apply suggestions from code review

Co-authored-by: Paul Masurel <paul@quickwit.io>

---------

Co-authored-by: Paul Masurel <paul@quickwit.io>
ethever pushed a commit to ethever/tantivy that referenced this issue Aug 30, 2023
@PSeitz @fulmicoton
add missing parameter for stats,min,max,count,sum,avg (quickwit-oss#2151
1bb774f 
)

* add missing parameter for stats,min,max,count,sum,avg

add missing parameter for stats,min,max,count,sum,avg
closes quickwit-oss#1913
partially quickwit-oss#1789

* Apply suggestions from code review

Co-authored-by: Paul Masurel <paul@quickwit.io>

---------

Co-authored-by: Paul Masurel <paul@quickwit.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PSeitz PSeitz

Labels
high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add missing aggregation part 2 quickwit-oss/tantivy
3 participants
@fulmicoton @PSeitz @guilload