Expose StreamState #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The feature is there by default and just enables the `mmap` feature in the fst crate when enabled. Closes BurntSushi#70
The lazy_static 1.2 release increases the minimum Rust version, so we do the same.
Just fixing mardown. (The image didn't show on docs.rs, because of the newline.)
Reading the docs previously was a bit confusing ‒ while the nature of the operation hints at exactly one IndexValue, the interface hints at arbitrary number and the docs kind of did too and one has to wonder what the trick is. Pointing it out explicitly should prevent the latter. PR BurntSushi#76
It's like to_vec, but without making copies. The reason why it didn't already exist is because the &[u8] tends to be a memory map, or at the very least, could be a memory map. In that circumstance, getting access to the raw slice without needing to type unsafe would be bad. With that said, since the last release, constructing an FST from a memory map now requires typing unsafe. There is even a safe method called as_bytes on the MmapReadOnly type. So to that end, the absence of this method was likely an oversight, and should now be an okay addition. PR BurntSushi#77
These are useful for constructing sets/maps directly from raw bytes. PR BurntSushi#80
This adds ability to match exact strings against the given set, as well as enables trie usecase by combining it with `StartsWith<_>`. We could have implemented `Automaton` for `&[u8]`/`&str` directly, but this path is a bit more conservative for now. PR BurntSushi#79
fulmicoton
reviewed
Aug 5, 2019
src/lib.rs
Outdated
| @@ -13,7 +15,7 @@ pub use error::{Error, Result}; | |||
| pub use map::{Map, MapBuilder}; | |||
| pub use stream::{IntoStreamer, Streamer}; | |||
|
|
|||
| mod regex; | |||
| pub mod regex; | |||
There was a problem hiding this comment.
I think you added that to fix a doctest. This is not needed. The problem is fixed in master
fulmicoton
reviewed
Aug 5, 2019
src/map.rs
Outdated
| type Item = (&'a [u8], u64, A::State); | ||
|
|
||
| fn next(&'a mut self) -> Option<Self::Item> { | ||
| /// My IDE Does not like this, and if I pub this function the compile fails, I'm a bit confused |
There was a problem hiding this comment.
remove this comment.
what did you mean by "pub" this function?
There was a problem hiding this comment.
if I write pub fn next(...) instead of just fn next(...) the code does not compile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR From BurntSushi#61 retrofitted here.