feat(ts): Introduce Volar support and event types #10839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…initions as separate interfaces These changes aims to improve Volar support and increase the reusability of types
IlCallo
reviewed
Sep 28, 2021
… spaces Also moved it to a constant variable to improve readability
The output is much more readable now
|
@yusufkandemir Hey, is it inside the latest release ? |
yusufkandemir
deleted the
feat-ts-add-volar-support-and-handle-event-types
branch
|
@soulsam480 we haven't released it yet. But it will be on the next release of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
devbranchOther information:
I added some logic to provide components to the
GlobalComponentsinterface in@vue/runtime-core. This is mainly for Volar support ATM, but it will soon be shipped officially(vuejs/core#3399), so it could become even more useful. Also, I extracted props definitions to separate interfaces, it's nice for reusability(h(),TSX, or extending components), it's a really common practice in Vue's and its official packages(e.g.vue-router) source code. (e.g. https://github.com/vuejs/vue-router-next/blob/5dd5f47515186ce34efb9118dda5aad0bb773439/src/RouterView.ts#L31-L35)Screenshots
Component name auto completion:
Props auto completion:
Prop types and description:
Required prop missing errors:
Event auto completion:
Event description and payload types:
See #10619