Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify ErasedSegment::make_mut #1217

Merged
merged 1 commit into from
Jan 17, 2025
Merged

refactor: simplify ErasedSegment::make_mut #1217

merged 1 commit into from
Jan 17, 2025

Conversation

gvozdvmozgu
Copy link
Collaborator

No description provided.

Copy link

Benchmark for 5cb7dc8

Click to view benchmark
Test Base PR %
DepthMap::from_parent 38.3±0.25µs 38.4±0.25µs +0.26%
fix_complex_query 9.3±0.21ms 9.3±0.60ms 0.00%
fix_superlong 92.6±5.27ms 91.7±5.32ms -0.97%
parse_complex_query 3.1±0.04µs 2.9±0.04µs -6.45%
parse_expression_recursion 5.3±0.05µs 5.1±0.03µs -3.77%
parse_simple_query 891.7±9.54ns 802.2±10.69ns -10.04%

@benfdking benfdking merged commit 3dad147 into main Jan 17, 2025
36 checks passed
@benfdking benfdking deleted the make_mut branch January 17, 2025 12:24
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jan 28, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [quarylabs/sqruff](https://github.com/quarylabs/sqruff) | minor | `v0.23.1` -> `v0.24.3` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>quarylabs/sqruff (quarylabs/sqruff)</summary>

### [`v0.24.3`](https://github.com/quarylabs/sqruff/releases/tag/v0.24.3)

[Compare Source](quarylabs/sqruff@v0.24.2...v0.24.3)

#### What's Changed

-   feat: implementing jinja templater by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1222
-   chore: bump indexmap from 2.7.0 to 2.7.1 by [@&#8203;dependabot](https://github.com/dependabot) in quarylabs/sqruff#1224
-   chore: bump [@&#8203;types/react](https://github.com/types/react) from 19.0.6 to 19.0.7 by [@&#8203;dependabot](https://github.com/dependabot) in quarylabs/sqruff#1228
-   chore: bump [@&#8203;types/node](https://github.com/types/node) from 22.10.5 to 22.10.7 by [@&#8203;dependabot](https://github.com/dependabot) in quarylabs/sqruff#1230
-   chore: bump serde_json from 1.0.135 to 1.0.137 by [@&#8203;dependabot](https://github.com/dependabot) in quarylabs/sqruff#1225
-   chore: update node deps jan 20 by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1233
-   feat: Add verbosity config to OutputStreamFormatter by [@&#8203;duvenagep](https://github.com/duvenagep) in quarylabs/sqruff#1234
-   refactor: remove unused `AsAny` trait and its implementation by [@&#8203;gvozdvmozgu](https://github.com/gvozdvmozgu) in quarylabs/sqruff#1235
-   fix: allow arbitrary expressions in sqlite by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1240
-   feat: enhance command descriptions for lint and fix commands by [@&#8203;gvozdvmozgu](https://github.com/gvozdvmozgu) in quarylabs/sqruff#1237
-   refactor: simplify filename formatting by removing `IntoStatus` trait by [@&#8203;gvozdvmozgu](https://github.com/gvozdvmozgu) in quarylabs/sqruff#1236
-   chore: bump version by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1241

**Full Changelog**: quarylabs/sqruff@v0.24.2...v0.24.3

### [`v0.24.2`](https://github.com/quarylabs/sqruff/releases/tag/v0.24.2)

[Compare Source](quarylabs/sqruff@v0.24.1...v0.24.2)

#### What's Changed

-   chore: turn on all features for tests by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1213
-   chore: update rust version by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1215
-   refactor: replace sptr polyfill with std equivalent by [@&#8203;gvozdvmozgu](https://github.com/gvozdvmozgu) in quarylabs/sqruff#1216
-   refactor: simplify `ErasedSegment::make_mut` by [@&#8203;gvozdvmozgu](https://github.com/gvozdvmozgu) in quarylabs/sqruff#1217
-   chore: make config simpler for templaters by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1211
-   docs: Added Redshift to supported dialects by [@&#8203;duvenagep](https://github.com/duvenagep) in quarylabs/sqruff#1218
-   feat: add code to dianostic by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1220
-   chore: bump version 24.2 by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1221

#### New Contributors

-   [@&#8203;duvenagep](https://github.com/duvenagep) made their first contribution in quarylabs/sqruff#1218

**Full Changelog**: quarylabs/sqruff@v0.24.1...v0.24.2

### [`v0.24.1`](https://github.com/quarylabs/sqruff/releases/tag/v0.24.1)

[Compare Source](quarylabs/sqruff@v0.23.1...v0.24.1)

#### What's Changed

-   chore: add superlong fix benchmark by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1208
-   fix: fix just the vscode version by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1210
-   refactor: remove `.clone()` for `LintFix` and `LintResult` by [@&#8203;gvozdvmozgu](https://github.com/gvozdvmozgu) in quarylabs/sqruff#1204
-   fix: fix vscode build by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1209
-   refactoring around `RuleContext` by [@&#8203;gvozdvmozgu](https://github.com/gvozdvmozgu) in quarylabs/sqruff#1202
-   chore: bump version 24 1 by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1214

**Full Changelog**: quarylabs/sqruff@v0.24.0...v0.24.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMzcuMiIsInVwZGF0ZWRJblZlciI6IjM5LjEzNy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants