Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a reliable way to perform form-based authentication logout #46429

Merged

Conversation

@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation area/rest area/vertx labels Feb 21, 2025
@michalvavrik michalvavrik force-pushed the feature/fix-form-auth-logout-logic branch from fd14cb0 to af368c3 Compare February 21, 2025 19:21

This comment has been minimized.

Copy link

github-actions bot commented Feb 21, 2025

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Michal, minor suggestion proposed

@michalvavrik michalvavrik force-pushed the feature/fix-form-auth-logout-logic branch from af368c3 to cc73513 Compare February 23, 2025 13:20
@michalvavrik michalvavrik added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 23, 2025
Copy link

quarkus-bot bot commented Feb 23, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit cc73513.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Feb 23, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit cc73513.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/hibernate-orm/deployment

io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest.testFieldAccess - History

  • Expecting actual not to be null - java.lang.AssertionError
java.lang.AssertionError: 

Expecting actual not to be null
	at io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest$FieldAccessEnhancedDelegate$1.assertValue(PublicFieldAccessInheritanceTest.java:141)
	at io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest.doTestFieldAccess(PublicFieldAccessInheritanceTest.java:100)
	at io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest.testFieldAccess(PublicFieldAccessInheritanceTest.java:61)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:513)

@sberyozkin sberyozkin merged commit b1da830 into quarkusio:main Feb 23, 2025
58 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 23, 2025
@quarkus-bot quarkus-bot bot added this to the 3.21 - main milestone Feb 23, 2025
@michalvavrik michalvavrik deleted the feature/fix-form-auth-logout-logic branch February 23, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflict between form-based auth logout and quarkus.http.auth.form.new-cookie-interval
2 participants