-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added config to control the behavior of check on null values in redis-cache extension #42189
base: main
Are you sure you want to change the base?
Added config to control the behavior of check on null values in redis-cache extension #42189
Conversation
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1093258
to
57dd347
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
57dd347
to
5a2d66a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@anadinema FYI, @cescoffier is on PTO so you'll get feedback when he's back. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🎊 PR Preview c146936 has been successfully built and deployed to https://quarkus-pr-main-42189-preview.surge.sh/version/main/guides/
|
LGTM. Can you rebase your PR? |
5a2d66a
to
9afd4a2
Compare
@cescoffier done ✅ Hope it's good to merge. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@cescoffier great that is happening! :) IMO this could be the cache extension SPI contract instead of having it specific to Redis since this looks more a generic behaviour of the caching api system rather than something specific to Redis |
@karesti yes. Also, I would like to discuss a change the the cache SPI to distinguished a cached |
@cescoffier let me know, in case the changes are to be made in the cache SPI itself. I can give it a try. |
I'm not sure if Infinispan can store |
Infinispan can do it, we handle this case with protostream and with java too, to provide null value caching for spring cache |
9afd4a2
to
db4c353
Compare
Status for workflow
|
Status for workflow
|
Implementation to achieve #42184
Please let me know if this is not at all suitable, or if suitable then do let me know if any fixes needed or if I missed something.