Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional GHA settings #894

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mhucka
Copy link
Contributor

@mhucka mhucka commented Mar 4, 2025

This adds some miscellaneous settings:

  • Set workflow default permissions as read-only (per security best
    practices)
  • Support merge queues
  • Support manual invocation (for debugging)
  • Make it so that starting another run of this workflow will cancel
    any ongoing runs for the same PR or branch (e.g., because a new push
    happened while the workflow is still running from a previous push)

This adds some miscellaneous settings:

- Set workflow default permissions as read-only (per security best
  practices)
- Support merge queues
- Support manual invocation (for debugging)
- Make it so that starting another run of this workflow will cancel
  any ongoing runs for the same PR or branch (e.g., because a new push
  happened while the workflow is still running from a previous push)
@mhucka mhucka self-assigned this Mar 4, 2025
@mhucka mhucka requested a review from Strilanc March 4, 2025 04:20
@Strilanc
Copy link
Collaborator

Strilanc commented Mar 4, 2025

If you can get merge queues working smoothly, I'd absolutely use them. Last time I tried I failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants