Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add GlobalPhase bloq #828

Merged
merged 5 commits into from
Mar 28, 2024
Merged

add GlobalPhase bloq #828

merged 5 commits into from
Mar 28, 2024
+268 −2

Conversation

anurudhp
Copy link
Contributor

No description provided.

@anurudhp anurudhp mentioned this pull request Mar 27, 2024
Merged
8 tasks
@tanujkhattar tanujkhattar enabled auto-merge (squash) March 27, 2024 17:37
@anurudhp
Copy link
Contributor Author 

E           qualtran.testing.BloqCheckException: Serialization Failed:
E           Cannot serialize 1j of unknown type <class 'complex'>

How do we serialize complex numbers?

@tanujkhattar
Copy link
Collaborator

We currently don't, please open an issue and add GlobalPhase bloq to the not yet serializable list in assert_bloq_example_serialize_for_pytest and the tests will pass. We can fix the serialization in a follow up PR

auto-merge was automatically disabled March 27, 2024 22:11

Head branch was pushed to by a user without write access

@anurudhp anurudhp mentioned this pull request Mar 27, 2024
Closed
@tanujkhattar tanujkhattar enabled auto-merge (squash) March 28, 2024 02:04
@tanujkhattar tanujkhattar merged commit 2f04a95 into quantumlib:main Mar 28, 2024
6 checks passed
@anurudhp anurudhp deleted the global-phase-op branch March 28, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanujkhattar tanujkhattar tanujkhattar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anurudhp @tanujkhattar