-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[open-systems] QCDType, CDType, QDType #1584
Open
mpharrigan
wants to merge
39
commits into
quantumlib:main
Choose a base branch
from
mpharrigan:2025-03/classical-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is the first in a series for supporting open system (classical data & measurement), roadmap item #445.
QCDType
QDType
base class for quantum data types now descends from the more generalQCDType
.CDType
is introduced to represent classical data types.CBit
is added, which is a single classical bit (analogous toQBit
).Register
'sdtype
argument can be either quantum or classical._ControlledBase
Controlled
. The circuit-implementation-agnostic bit is now in_ControlledBase
from whichControlled
(which uses a "total control" circuit) andControlledViaAnd
descend.CtrlSpec
supports classical data types (CDType
)ClassicallyControlled
metabloqDrawing
Documentation
QDType
system was not really documented (at least not with its own notebook). I went ahead and wrote docs for the data type system.QCDType
class hierarchyNaming
qdtype: QDType
anddtype: QDType
have been used interchangeably. After this PR, idiomatically:qdtype
should be the variable name used for aQDType
anddtype
should be reserved for variables that can be either quantum or classical (i.e.QCDType
). Where the variable name isn't backwards-compatibility breaking, I've made those changes in this PR; but there are many places wheredtype
is used whereqdtype
would be more appropriatebitsize
andnum_qubits
(as variable/method names) have been used interchangeably. This PR adds methods/properties that aim to disambiguate these quantities.bitsize
ornum_bits
is the total number of quantum and/or classical bits.num_qubits
is strictly qubits (resource counting still counts strictly qubits).num_cbits
is added; which is the number of strictly classical qubits.Non-changes (yet)
CDType
,CBit
, andCtrlSpec(CBit())
are introduced, there's no real way to use them (with the exception ofCast
, which is likely not what you really want).