Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .markdownlintrc config file for markdownlint #1571

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

mhucka
Copy link
Contributor

@mhucka mhucka commented Feb 27, 2025

This configures markdownlint, a Markdown linter/formatter, to follow the Google style guide for Markdown as closely as possible. This allows users to use markdownlint when writing and editing Markdown files, and gets us ready to add a Markdown linter check in the CI workflow.

This configures `markdownlint`, a Markdown linter/formatter, to follow
the Google style guide for Markdown as closely as possible. This
allows users to use `markdownlint` when writing and editing Markdown
files, and gets us ready to add a Markdown linter check in the CI workflow.
@mhucka mhucka marked this pull request as ready for review February 27, 2025 20:39
@mhucka mhucka enabled auto-merge (squash) February 27, 2025 20:39
@mpharrigan
Copy link
Collaborator

what's the intended use? we have very few true markdown files in the repository. (a lot more if you count docstrings, jupyter notebooks, and autogenerated api docs)

@mhucka
Copy link
Contributor Author

mhucka commented Feb 27, 2025

what's the intended use? we have very few true markdown files in the repository. (a lot more if you count docstrings, jupyter notebooks, and autogenerated api docs)

That's a fair question. I'm about to add several more md files; in addition, with the other Quantumlib projects using Markdown more heavily, I hope to see the Qualtran project from rST to md for their docs/ too … (But even if that doesn't happen, there will always be several Markdown files, and IMHO it's worth automating style checks if there's more than one.)

@mpharrigan
Copy link
Collaborator

We don't actually use rst either. We use the myst-nb sphinx plugin to take jupyter notebooks (which indeed use markdown cells) and turn them into docs pages via the sphinx doc builder

@mhucka mhucka merged commit 9f45795 into quantumlib:main Feb 27, 2025
8 checks passed
@mhucka
Copy link
Contributor Author

mhucka commented Feb 27, 2025

We don't actually use rst either. We use the myst-nb sphinx plugin to take jupyter notebooks (which indeed use markdown cells) and turn them into docs pages via the sphinx doc builder

Oh, I see. Good to know!

I'm examining ipynb linters too, but don't know yet if markdownlint can be made part of that. (Hopefully it can, so that the same config will work everywhere.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants