Code

Fix bugs in ECAdd bloq#1489

Code

Merged

mpharrigan merged 18 commits intoquantumlib:mainquantumlib/Qualtran:mainfrom fpapa250:ecc-fix-addfpapa250/Qualtran:ecc-fix-addCopy head branch name to clipboardMar 6, 2025

Commits

Commits on Nov 4, 2024

• fix som ebugs

  fpapa250

  committed
  af46d88

  Copy full SHA for af46d88

• remove one dirty statement

  fpapa250

  committed
  1755ef4

  Copy full SHA for 1755ef4

Commits on Nov 5, 2024

• Merge branch 'main' into ecc-fix-add

  fpapa250

  committed
  b97ac02

  Copy full SHA for b97ac02

Commits on Nov 7, 2024

• Correct the rest of the ECAdd bugs from the paper

  fpapa250

  committed
  1ddc3ee

  Copy full SHA for 1ddc3ee

• Fix symbolic cvs for step 5

  fpapa250

  committed
  9a83d8e

  Copy full SHA for 9a83d8e

Commits on Nov 27, 2024

• Merge branch 'main' into ecc-fix-add

  fpapa250

  committed
  c5668d5

  Copy full SHA for c5668d5

• Merge branch 'main' into ecc-fix-add

  fpapa250

  committed
  2f52006

  Copy full SHA for 2f52006

• Fix final test with Equals.controlled working

  fpapa250

  committed
  6da2b0e

  Copy full SHA for 6da2b0e

Commits on Nov 29, 2024

• Update qualtran/bloqs/factoring/ecc/ec_add.py

  Show description for 64e3989
  

  fpapa250

  and

  anurudhp

  authored
  64e3989

  Copy full SHA for 64e3989

• formatting

  fpapa250

  committed
  15fa7c5

  Copy full SHA for 15fa7c5

Commits on Feb 4, 2025

• Merge branch 'main' into ecc-fix-add

  fpapa250

  committed
  3694769

  Copy full SHA for 3694769

Commits on Feb 13, 2025

• Merge branch 'main' into ecc-fix-add

  fpapa250

  committed
  500f8b2

  Copy full SHA for 500f8b2

• Solve nit

  fpapa250

  committed
  af3563c

  Copy full SHA for af3563c

Commits on Mar 3, 2025

• Fix nits for ECAdd

  fpapa250

  committed
  70facd9

  Copy full SHA for 70facd9

• Merge branch 'main' into ecc-fix-add

  fpapa250

  committed
  f4735c3

  Copy full SHA for f4735c3

• Update gate counts test to reflect counts using simplified circuits

  fpapa250

  committed
  e7a77f6

  Copy full SHA for e7a77f6

Commits on Mar 5, 2025

• Merge branch 'main' into ecc-fix-add

  fpapa250

  committed
  1e2d6e8

  Copy full SHA for 1e2d6e8

• Further clarify in test comment

  fpapa250

  committed
  451de48

  Copy full SHA for 451de48