Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore cirq_google.api.v2 protos deleted in 6442 #6746

Merged

Conversation

pavoljuhas
Copy link
Collaborator

Restore proto files that are still used by internal code.
This reverts small part of #6442.

These are needed in an internal code.
Executed  dev_tools/build-protos.sh
@pavoljuhas pavoljuhas requested review from wcourtney, vtomole, verult and a team as code owners September 27, 2024 00:06
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.83%. Comparing base (756abe3) to head (b5cebd3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6746   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files        1077     1077           
  Lines       92558    92558           
=======================================
  Hits        90555    90555           
  Misses       2003     2003           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavoljuhas
Copy link
Collaborator Author

Related to b/369459111

Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

Copy link
Collaborator

@senecameeks senecameeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavoljuhas pavoljuhas merged commit ce1d903 into quantumlib:main Sep 27, 2024
37 checks passed
@pavoljuhas pavoljuhas deleted the cirq_google-restore-api.v2-protos branch September 27, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants