Fix CI lint failure by pinning to protobuf-4 #6650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavoljuhas
requested review from
wcourtney,
vtomole,
cduck,
verult and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6650 +/- ##
==========================================
- Coverage 97.81% 97.81% -0.01%
==========================================
Files 1066 1066
Lines 91779 91779
==========================================
- Hits 89773 89772 -1
- Misses 2006 2007 +1 ☔ View full report in Codecov by Sentry. |
|
Related to protocolbuffers/protobuf@2699579 which was released in protobuf-5.27.0. |
senecameeks
approved these changes
Jun 25, 2024
dstrain115
approved these changes
Jun 25, 2024
pavoljuhas
added a commit
to pavoljuhas/Cirq
that referenced
this pull request
Jun 26, 2024
* Pin `protobuf` to version 4 to fix "Lint check" CI failure such as https://github.com/quantumlib/Cirq/actions/runs/9654153610/job/26627844188 * Also bump `types-protobuf` `mypy-protobuf` for consistency with protobuf-4.x
pavoljuhas
added a commit
to pavoljuhas/Cirq
that referenced
this pull request
Jun 26, 2024
* Pin `protobuf` to version 4 to fix "Lint check" CI failure such as https://github.com/quantumlib/Cirq/actions/runs/9654153610/job/26627844188 * Also bump `types-protobuf` `mypy-protobuf` for consistency with protobuf-4.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin
protobufto version 4 to fix "Lint check" CI failure such ashttps://github.com/quantumlib/Cirq/actions/runs/9654153610/job/26627844188
Also bump
types-protobufmypy-protobuffor consistency with protobuf-4.x