Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update start doc to specify recommended python version #6370

Merged
merged 5 commits into from
Dec 6, 2023

Conversation

senecameeks
Copy link
Collaborator

Using python version's less than 3.11 result in error

cc: @aasfaw

Using python version's less than 3.11 result in error
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

delete comma
@@ -101,7 +101,7 @@
"\n",
"Access is currently restricted to those in an approved group, and you must be in that group before running this tutorial.\n",
"\n",
"You can find more about running this in colaboratory in the [Colab documentation](https://colab.research.google.com/notebooks/welcome.ipynb) or in our Cirq-specific guide to [running in Colab](colab.ipynb). You can download this notebook from the [GitHub repository](https://github.com/quantumlib/Cirq/blob/main/docs/tutorials/google/start.ipynb)."
"You can find more about running this in colaboratory in the [Colab documentation](https://colab.research.google.com/notebooks/welcome.ipynb) or in our Cirq-specific guide to [running in Colab](colab.ipynb). You can download this notebook from the [GitHub repository](https://github.com/quantumlib/Cirq/blob/main/docs/tutorials/google/start.ipynb). It is recommended that your colab runs using Python 3.11 or greater."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this isn't an issue in Colab since they don't use gcloud. Abe ran into this in the command line flow while setting up auth, so maybe include it in the auth section?

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (30b6c39) 97.80% compared to head (861f0ee) 97.80%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6370      +/-   ##
==========================================
- Coverage   97.80%   97.80%   -0.01%     
==========================================
  Files        1111     1111              
  Lines       96878    96877       -1     
==========================================
- Hits        94755    94750       -5     
- Misses       2123     2127       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@senecameeks senecameeks requested a review from wcourtney December 5, 2023 22:06
Copy link
Collaborator

@wcourtney wcourtney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@senecameeks senecameeks merged commit 6d437c4 into main Dec 6, 2023
@pavoljuhas pavoljuhas deleted the senecameeks-patch-2 branch January 22, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants