-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update start doc to specify recommended python version #6370
Conversation
Using python version's less than 3.11 result in error
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
docs/tutorials/google/start.ipynb
Outdated
@@ -101,7 +101,7 @@ | |||
"\n", | |||
"Access is currently restricted to those in an approved group, and you must be in that group before running this tutorial.\n", | |||
"\n", | |||
"You can find more about running this in colaboratory in the [Colab documentation](https://colab.research.google.com/notebooks/welcome.ipynb) or in our Cirq-specific guide to [running in Colab](colab.ipynb). You can download this notebook from the [GitHub repository](https://github.com/quantumlib/Cirq/blob/main/docs/tutorials/google/start.ipynb)." | |||
"You can find more about running this in colaboratory in the [Colab documentation](https://colab.research.google.com/notebooks/welcome.ipynb) or in our Cirq-specific guide to [running in Colab](colab.ipynb). You can download this notebook from the [GitHub repository](https://github.com/quantumlib/Cirq/blob/main/docs/tutorials/google/start.ipynb). It is recommended that your colab runs using Python 3.11 or greater." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this isn't an issue in Colab since they don't use gcloud. Abe ran into this in the command line flow while setting up auth, so maybe include it in the auth section?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6370 +/- ##
==========================================
- Coverage 97.80% 97.80% -0.01%
==========================================
Files 1111 1111
Lines 96878 96877 -1
==========================================
- Hits 94755 94750 -5
- Misses 2123 2127 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Using python version's less than 3.11 result in error
cc: @aasfaw