rm modules that no longer exist #6348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6348 +/- ##
==========================================
- Coverage 97.84% 97.84% -0.01%
==========================================
Files 1110 1110
Lines 96656 96656
==========================================
- Hits 94572 94571 -1
- Misses 2084 2085 +1 ☔ View full report in Codecov by Sentry. |
pavoljuhas
reviewed
Nov 22, 2023
Comment on lines
-37
to
-42
| import cirq_aqt | ||
| import cirq_google | ||
| import cirq_ionq | ||
| import cirq_pasqal | ||
| import cirq_rigetti | ||
| import cirq_web |
There was a problem hiding this comment.
All of these import fine in my dev environment and also in a fresh virtual environment after pip install cirq.
Am I missing something?
There was a problem hiding this comment.
This is outdated and no longer applicable. I was able to find a way around the tensorflow nightly automation tool failing in #6360. Closing this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the reason, the nightly borgcron job might not be successful is that this file produces errors due to importing modules that don't exist. e.g
cirq-aqtAfter removing these modules I was able to successfully run the script manually.