Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable spacing QROM should depend upon structure of different data sequences and not exact elements #6280

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Variable spacing QROM should depend upon structure of different data sequences and not exact elements #6280

merged 1 commit into from
Sep 6, 2023

Conversation

tanujkhattar
Copy link
Collaborator

Fixes #6279

@tanujkhattar tanujkhattar requested review from vtomole, cduck and a team as code owners September 6, 2023 18:08
@tanujkhattar tanujkhattar requested a review from dabacon September 6, 2023 18:08
@CirqBot CirqBot added the size: S 10< lines changed <50 label Sep 6, 2023
fdmalone
fdmalone approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@fdmalone fdmalone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanujkhattar tanujkhattar enabled auto-merge (squash) September 6, 2023 18:16
@tanujkhattar tanujkhattar merged commit e235642 into quantumlib:master Sep 6, 2023
@tanujkhattar tanujkhattar added the area/cirq-ft Issues related to the Cirq-FT sub-package label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdmalone fdmalone fdmalone approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@dabacon dabacon Awaiting requested review from dabacon dabacon was automatically assigned from quantumlib/cirq-maintainers

Assignees

@fdmalone fdmalone

Labels
area/cirq-ft Issues related to the Cirq-FT sub-package size: S 10< lines changed <50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with variable spaced QROM
3 participants
@tanujkhattar @fdmalone @CirqBot