-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tags to cirq.FrozenCircuit
#6266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good modulo few nits.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6266 +/- ##
========================================
Coverage 97.60% 97.61%
========================================
Files 1116 1116
Lines 95848 95973 +125
========================================
+ Hits 93556 93680 +124
- Misses 2292 2293 +1
☔ View full report in Codecov by Sentry. |
This looks pretty awkward to use. Since you usually get a FrozenCircuit from circuit.freeze(), should we add circuit.freeze(tags=tags) or a cirq.freeze_with_tags(tags)? |
* Add tags to FrozenCircuit * Address comments and fix tests * Address maffoo's comments
Fixes #6265
Things left to do as a follow up
cirq.FrozenCircuit
to print the tags if they exist