codecov - fix syntax for excluding code lines from coverage #6240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spurious codecov deltas will hopefully go away this time.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #6240 +/- ##
======================================
Coverage 97.3% 97.3%
======================================
Files 1116 1116
Lines 96174 96154 -20
======================================
- Hits 93651 93641 -10
+ Misses 2523 2513 -10
☔ View full report in Codecov by Sentry. |
The `coverage` package obeys `# pragma: no cover`. The previous syntax `# coverage: ignore` has no effect.
The spurious coverage deltas should go away after fixed code exclusion.
pavoljuhas
changed the title
pavoljuhas
added a commit
to pavoljuhas/Cirq
that referenced
this pull request
Aug 15, 2023
…sion Rebase after quantumlib#6240 is in.
dstrain115
approved these changes
Aug 15, 2023
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
…ib#6240) The `coverage` tool understands `# pragma: no cover` markup comments to exclude code lines from coverage analysis. The previous syntax `# coverage: ignore` had no effect and resulted in spurious coverage changes for a different code paths taken. Removing the codecov.yml file, because coverage precision had no effect on codecov complaints about decreased coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
coveragetool understands# pragma: no covermarkup comments to excludecode lines from coverage analysis. The previous syntax
# coverage: ignorehad no effect and resulted in spurious coverage changes for a different code
paths taken.
Removing the codecov.yml file, because coverage precision had no effect on
codecov complaints about decreased coverage.