Fix failing tests for Python 3.11 #6181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssages This commit addresses the failing tests in the cirq-core module when run with Python 3.11. The failures were due to changes in the error messages associated with the `@property` annotation in Python 3.11. The changes in this commit include: 1. Updating the expected error messages in the test cases to match either the old or the new error message format. 2. Modifying the `__repr__` method in the `MeasurementType` class in `classical_data.py` to correctly represent the enum value. These changes ensure that the tests pass for both Python 3.11 and earlier versions.
tanujkhattar
approved these changes
Jul 5, 2023
pavoljuhas
approved these changes
Jul 6, 2023
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
This commit addresses the failing tests in the cirq-core module when run with Python 3.11. The failures were due to changes in the error messages associated with the `@property` annotation in Python 3.11. The changes in this commit include: 1. Updating the expected error messages in the test cases to match either the old or the new error message format. 2. Modifying the `__repr__` method in the `MeasurementType` class in `classical_data.py` to correctly represent the enum value. These changes ensure that the tests pass for both Python 3.11 and earlier versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses the failing tests in the cirq-core module when run with Python 3.11. The failures were due to changes in the error messages associated with the
@propertyannotation in Python 3.11.The changes in this commit include:
__repr__method in theMeasurementTypeclass inclassical_data.pyto correctly represent the enum value.These changes ensure that the tests pass for both Python 3.11 and earlier versions.