-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add _phase_by_ method to ZZPowGate #6062
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments:
- Please sign the CLA.
- Optional: It'd be good to add a unit test (e.g. comparing the outcome of
_phase_by_
to a circuit that conjugatesZZPowGate
).
done.
added a simple test (which just checks that the output of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
this was motivated by
cirq.eject_z
failing to commute through ZZPowGates, for example:output before:
output after adding
_phase_by_
:(ZZPowGate is diagonal so this implementation is trivial)