-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small housekeeping in check/pytest #5899
Conversation
Per install.md we require Python 3.7.
Run pytest with `-n=auto` by default. Append optional `-n N` on command line to override. check/pytest now obeys `-n0` as well as `-n 0`.
@vtomole - can you PTAL? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do i call this correctly?
(cirq_venv) vtomole@vtomole:~/Cirq$ ./check/pytest -n0
ERROR: usage: pytest [options] [file_or_dir] [file_or_dir] [...]
pytest: error: unrecognized arguments: -n0 -n=auto
inifile: /home/vtomole/Cirq/pyproject.toml
rootdir: /home/vtomole/Cirq
The Please try again after |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works 👍
- Clean up special-casing for Python 3.6 as we require Python 3.7. - Simplify handling of the parallel job count `-n COUNT` option in check/pytest. Obey the `-n0` option on the command line in addition to `-n 0` to request non-parallel testing.
Clean up special-casing for Python 3.6 as we require Python 3.7.
Simplify handling of the parallel job count
-n COUNT
option in check/pytest.Obey the
-n0
option on the command line in addition to-n 0
torequest non-parallel testing.