Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential fix for unclickable sidebar heading #5842

Merged

Conversation

augustehirth
Copy link
Collaborator

Minor addition to fix unclickable "Algorithms in ReCirq" heading in the "Experiments" tab sidebar.

b/244171974

@wcourtney

@CirqBot CirqBot added the Size: XS <10 lines changed label Aug 29, 2022
Copy link
Collaborator

@wcourtney wcourtney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted in the bug, this may not resolve the fundamental structure issue but approving since I'm fine with either way for now.

@augustehirth
Copy link
Collaborator Author

Includes quantumlib/ReCirq#319 as a supporting change.

Copy link
Collaborator

@wcourtney wcourtney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved. Much better; thanks for addressing my concerns!

@augustehirth augustehirth marked this pull request as ready for review August 29, 2022 21:11
@augustehirth augustehirth requested review from a team, vtomole and cduck as code owners August 29, 2022 21:11
@95-martin-orion 95-martin-orion merged commit e0217f5 into quantumlib:master Aug 29, 2022
@augustehirth augustehirth deleted the experiments_sidebar_fix branch August 29, 2022 21:27
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
* Potential fix for unclickable sidebar heading

* Remove empty heading, pair with recirq pr

* Add to index explanation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants