Fix more flakes #5537
Merged
Fix more flakes #5537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -265,4 +265,4 @@ def test_decompose_to_diagonal_and_circuit(v): | |||
| assert cirq.is_diagonal(diagonal) | |||
| combined_circuit = cirq.Circuit(cirq.MatrixGate(diagonal)(b, c), ops) | |||
| circuit_unitary = combined_circuit.unitary(qubits_that_should_be_present=[b, c]) | |||
| cirq.testing.assert_allclose_up_to_global_phase(circuit_unitary, v, atol=2e-6) | |||
| cirq.testing.assert_allclose_up_to_global_phase(circuit_unitary, v, atol=1e-5) | |||
There was a problem hiding this comment.
[No change needed] I've seen relative difference in excess of 1e-5, but absolute is still below that mark.
Max absolute difference: 5.1897987e-06
Max relative difference: 1.1158966e-05
There was a problem hiding this comment.
yeah I am giving it some room
There was a problem hiding this comment.
Just hit this again with worse error:
Max absolute difference: 4.5085162e-05
Max relative difference: 0.00063814
https://github.com/quantumlib/Cirq/runs/6926634541?check_suite_focus=true
95-martin-orion
approved these changes
Jun 16, 2022
MichaelBroughton
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
CirqBot
pushed a commit
that referenced
this pull request
Jun 29, 2022
…final_state_vector (#5636) Rolls back change in #5426 that set the default precision on `Circuit#unitary` to `np.complex128`. Also sets the default on `Circuit#final_state_vector` to `np.complex128`. There was a deprecation warning that this was going to be downgraded to `np.complex64`,, but this will now remain `np.complex128`. This is breaking in that is someone explicitly passed `dtype=None` to this method it would now break. Rolls back #5426 #5616 #5537 #5535
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…final_state_vector (quantumlib#5636) Rolls back change in quantumlib#5426 that set the default precision on `Circuit#unitary` to `np.complex128`. Also sets the default on `Circuit#final_state_vector` to `np.complex128`. There was a deprecation warning that this was going to be downgraded to `np.complex64`,, but this will now remain `np.complex128`. This is breaking in that is someone explicitly passed `dtype=None` to this method it would now break. Rolls back quantumlib#5426 quantumlib#5616 quantumlib#5537 quantumlib#5535
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
…final_state_vector (quantumlib#5636) Rolls back change in quantumlib#5426 that set the default precision on `Circuit#unitary` to `np.complex128`. Also sets the default on `Circuit#final_state_vector` to `np.complex128`. There was a deprecation warning that this was going to be downgraded to `np.complex64`,, but this will now remain `np.complex128`. This is breaking in that is someone explicitly passed `dtype=None` to this method it would now break. Rolls back quantumlib#5426 quantumlib#5616 quantumlib#5537 quantumlib#5535
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5536