Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass through None during param resolution #5466

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Pass through None during param resolution #5466

merged 1 commit into from
Jun 7, 2022

Conversation

dstrain115
Copy link
Collaborator

  • pass through None as a parameter if set.

Technically a breaking change, since this used to silently drop parameters that were set as None.

Fixes: #4029

@dstrain115
Pass through None during param resolution
1ea9103 
- pass through None as a parameter if set.

Fixes: quantumlib#4029
@dstrain115 dstrain115 added the BREAKING CHANGE For pull requests that are important to mention in release notes. label Jun 7, 2022
@dstrain115 dstrain115 requested review from a team, vtomole and cduck as code owners June 7, 2022 19:57
@dstrain115 dstrain115 requested review from viathor and zchen088 June 7, 2022 19:57
@CirqBot CirqBot added the Size: XS <10 lines changed label Jun 7, 2022
MichaelBroughton
MichaelBroughton approved these changes Jun 7, 2022
View reviewed changes
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from issue discussion.

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 7, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 7, 2022
@CirqBot CirqBot merged commit 9f37af1 into quantumlib:master Jun 7, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 7, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@dstrain115 @rht
Pass through None during param resolution (quantumlib#5466)
2e55821 
- pass through None as a parameter if set.

Technically a breaking change, since this used to silently drop parameters that were set as None. 

Fixes: quantumlib#4029
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@dstrain115
Pass through None during param resolution (quantumlib#5466)
3ee782e 
- pass through None as a parameter if set.

Technically a breaking change, since this used to silently drop parameters that were set as None. 

Fixes: quantumlib#4029
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelBroughton MichaelBroughton MichaelBroughton approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@viathor viathor Awaiting requested review from viathor viathor was automatically assigned from quantumlib/cirq-maintainers

@zchen088 zchen088 Awaiting requested review from zchen088

Assignees
No one assigned
Labels
BREAKING CHANGE For pull requests that are important to mention in release notes. Size: XS <10 lines changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should _resolve_value pass None through?
3 participants
@dstrain115 @MichaelBroughton @CirqBot