Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialize QubitPermutationGate. #5092

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Serialize QubitPermutationGate. #5092

merged 2 commits into from
Mar 17, 2022

Conversation

MichaelBroughton
Copy link
Collaborator

@MichaelBroughton MichaelBroughton commented Mar 17, 2022 •
edited by tanujkhattar
Loading

Step towards fixing #5090

@MichaelBroughton MichaelBroughton requested review from a team, vtomole and cduck as code owners March 17, 2022 03:07
@MichaelBroughton MichaelBroughton requested a review from maffoo March 17, 2022 03:07
@CirqBot CirqBot added the size: S 10< lines changed <50 label Mar 17, 2022
@tanujkhattar
Copy link
Collaborator

@MichaelBroughton Can you also add a _decompose_ method which decomposes into swaps? That will close the issue and will also be helpful towards the other roadmap item to decompose all gates to native gateset.

tanujkhattar
tanujkhattar approved these changes Mar 17, 2022
View reviewed changes
Copy link
Collaborator

@tanujkhattar tanujkhattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, let's handle the _decompose_ separately and keep the issue open.

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Mar 17, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Mar 17, 2022
@CirqBot CirqBot merged commit c153664 into quantumlib:master Mar 17, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Mar 17, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@MichaelBroughton @rht
Serialize QubitPermutationGate. (quantumlib#5092)
f38e849 
Step towards fixing quantumlib#5090
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@MichaelBroughton
Serialize QubitPermutationGate. (quantumlib#5092)
2ea535d 
Step towards fixing quantumlib#5090
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanujkhattar tanujkhattar tanujkhattar approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@maffoo maffoo Awaiting requested review from maffoo maffoo was automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
size: S 10< lines changed <50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelBroughton @tanujkhattar @CirqBot