Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return type annotation on MeasurementGate.full_invert_mask #5080

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

maffoo
Copy link
Contributor

@maffoo maffoo commented Mar 16, 2022

Add a return type annotation on MeasurementGate.full_invert_mask, which returns a tuple of the same length as the number of qubits. This is in contrast to the invert mask itself, which can be specified as a partial mask for just some of the qubits.

@maffoo maffoo requested review from a team, vtomole and cduck as code owners March 16, 2022 03:58
@maffoo maffoo requested a review from dabacon March 16, 2022 03:58
@CirqBot CirqBot added the Size: XS <10 lines changed label Mar 16, 2022
Copy link
Collaborator

@tanujkhattar tanujkhattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nits.

Also, please add a description.

Co-authored-by: Tanuj Khattar <tanujkhattar@google.com>
@maffoo maffoo requested a review from tanujkhattar March 16, 2022 04:20
@maffoo maffoo merged commit 701f62c into master Mar 16, 2022
@maffoo maffoo deleted the u/maffoo/full-invert-mask branch March 16, 2022 05:37
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
…umlib#5080)

Review: @tanujkhattar 
Co-authored-by: Tanuj Khattar <tanujkhattar@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants