Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type annotations to method overrides in child classes #5051

Merged
merged 2 commits into from
Mar 3, 2022
Merged

Add type annotations to method overrides in child classes #5051

merged 2 commits into from
Mar 3, 2022

Conversation

vtomole
Copy link
Collaborator

@vtomole vtomole commented Mar 2, 2022

Fixes: #554

@vtomole vtomole requested review from a team and cduck as code owners March 2, 2022 21:42
@vtomole vtomole requested a review from mpharrigan March 2, 2022 21:42
@CirqBot CirqBot added the size: S 10< lines changed <50 label Mar 2, 2022
MichaelBroughton
MichaelBroughton approved these changes Mar 3, 2022
View reviewed changes
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelBroughton MichaelBroughton self-assigned this Mar 3, 2022
@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Mar 3, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Mar 3, 2022
@CirqBot CirqBot merged commit cff7a8e into master Mar 3, 2022
@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Mar 3, 2022
@CirqBot CirqBot deleted the type_annot branch March 3, 2022 23:41
@CirqBot CirqBot removed the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Mar 3, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@vtomole @rht
Add type annotations to method overrides in child classes (quantumlib…
5791dc6 
…#5051)

Fixes: quantumlib#554
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@vtomole
Add type annotations to method overrides in child classes (quantumlib…
ed5a0a3 
…#5051)

Fixes: quantumlib#554
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelBroughton MichaelBroughton MichaelBroughton approved these changes

@cduck cduck Awaiting requested review from cduck

@mpharrigan mpharrigan Awaiting requested review from mpharrigan mpharrigan was automatically assigned from quantumlib/cirq-maintainers

Assignees

@MichaelBroughton MichaelBroughton

Labels
size: S 10< lines changed <50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add type annotations to method overrides in child classes
3 participants
@vtomole @MichaelBroughton @CirqBot