Add cirq.SqrtIswapTargetGateset for (parameterized & non-parameterized) compilation to sqrt iswaps.
#5025
Conversation
tanujkhattar
requested review from
wcourtney,
a team,
vtomole,
cduck and
verult
as code owners
There was a problem hiding this comment.
We are packing a lot into this PR and it's getting a little hard for me to follow test changes with deprecations woven in as well, would you mind splitting out the deprecation into a seperate PR ? Also why do we mention the support of measurement gates in this transformer it doesn't look like we are inserting measurements as a part of the circuit transformation process ?
cirq-core/cirq/transformers/target_gatesets/sqrt_iswap_gateset.py
Outdated
Show resolved
Hide resolved
…PR to remove deprecations
tanujkhattar
force-pushed
the
sqrt_iswap_gateset
branch
from
12456ac to
c87ae92
Compare
tanujkhattar
changed the title
cirq.SqrtIswapTargetGateset to replace cirq.MergeInteractionsToSqrtIswap and cg.ConvertToSqrtIswapGates.cirq.SqrtIswapTargetGateset for (parameterized & non-parameterized) compilation to sqrt iswaps.
|
@MichaelBroughton As discussed offline, I've removed deprecations from this PR and they will follow up in the next PR once this is checked in. I've also abstracted out the parameterized gate compilation logic to a The PR is ready for a re-review! PTAL |
| f')' | ||
| ) | ||
|
|
||
| def _value_equality_values_(self) -> Any: |
There was a problem hiding this comment.
Does this need a corresponding decorator on the top of the class to auto generate other equalities ?
There was a problem hiding this comment.
Equalities are auto generated because the class derives from cirq.Gateset, which is decorated with @value.value_equality().
Added additional tests to assert this.
| A parameterized `cirq.OP_TREE` implementing `op` using only `cirq.SQRT_ISWAP` | ||
| (or `cirq.SQRT_ISWAP_INV`) and parameterized single qubit rotations OR | ||
| None or NotImplemented if decomposition of `op` is not known. |
There was a problem hiding this comment.
Is it an op_tree or a DecomposeResult ? (from fxn return type hint)
There was a problem hiding this comment.
DecomposeResult is Union[cirq.OP_TREE, None, NotImplementedType] -- the docstring covers all 3 cases.
…zed) compilation to sqrt iswaps. (quantumlib#5025) * Move parameterized decomposition to analytical decomposers and split PR to remove deprecations * Add equality tests
…zed) compilation to sqrt iswaps. (quantumlib#5025) * Move parameterized decomposition to analytical decomposers and split PR to remove deprecations * Add equality tests
…zed) compilation to sqrt iswaps. (quantumlib#5025) * Move parameterized decomposition to analytical decomposers and split PR to remove deprecations * Add equality tests
cirq.SqrtIswapTargetGatesetprimitive.cc @MichaelBroughton @dstrain115