Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace fields with properties in ActOnArgs #5011

Merged
merged 2 commits into from
Feb 22, 2022
Merged

Replace fields with properties in ActOnArgs #5011

merged 2 commits into from
Feb 22, 2022

Conversation

daxfohl
Copy link
Collaborator

@daxfohl daxfohl commented Feb 22, 2022

@daxfohl daxfohl requested review from a team, vtomole and cduck as code owners February 22, 2022 22:09
@daxfohl daxfohl requested a review from tanujkhattar February 22, 2022 22:09
@CirqBot CirqBot added the size: M 50< lines changed <250 label Feb 22, 2022
@95-martin-orion 95-martin-orion self-assigned this Feb 22, 2022
@95-martin-orion 95-martin-orion self-requested a review February 22, 2022 22:19
95-martin-orion
95-martin-orion requested changes Feb 22, 2022
View reviewed changes
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add deprecation tests (i.e. with cirq.testing.assert_deprecated) for these fields.

@95-martin-orion 95-martin-orion added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Feb 22, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Feb 22, 2022
@CirqBot CirqBot merged commit ca4c8e7 into quantumlib:master Feb 22, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Feb 22, 2022
@daxfohl daxfohl deleted the privatevars branch February 22, 2022 23:03
95-martin-orion pushed a commit to 95-martin-orion/Cirq that referenced this pull request Mar 2, 2022
@daxfohl @95-martin-orion
Replace fields with properties in ActOnArgs (quantumlib#5011)
f8634f0 
xref quantumlib#4851 @95-martin-orion
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@daxfohl @rht
Replace fields with properties in ActOnArgs (quantumlib#5011)
05cb1b9 
xref quantumlib#4851 @95-martin-orion
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@daxfohl
Replace fields with properties in ActOnArgs (quantumlib#5011)
cfe4339 
xref quantumlib#4851 @95-martin-orion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@95-martin-orion 95-martin-orion 95-martin-orion approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@tanujkhattar tanujkhattar Awaiting requested review from tanujkhattar tanujkhattar was automatically assigned from quantumlib/cirq-maintainers

Assignees

@95-martin-orion 95-martin-orion

Labels
size: M 50< lines changed <250
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daxfohl @95-martin-orion @CirqBot