Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default decompositions for XXPowGate and YYPowGate which terminate in CZPowGate. #4862

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

tanujkhattar
Copy link
Collaborator

Part of #4858

Decompositions are tested as part of assert_eigengate_implements_consistent_protocols, which is already tested for both gates.

@tanujkhattar tanujkhattar requested review from cduck, vtomole and a team as code owners January 20, 2022 01:34
@tanujkhattar tanujkhattar requested a review from maffoo January 20, 2022 01:34
@CirqBot CirqBot added the size: S 10< lines changed <50 label Jan 20, 2022
@tanujkhattar tanujkhattar requested a review from viathor January 20, 2022 01:36
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jan 20, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jan 20, 2022
@CirqBot CirqBot merged commit fe80da7 into quantumlib:master Jan 20, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jan 20, 2022
MichaelBroughton pushed a commit to MichaelBroughton/Cirq that referenced this pull request Jan 22, 2022
…inate in `CZPowGate`. (quantumlib#4862)

Part of quantumlib#4858

Decompositions are tested as part of `assert_eigengate_implements_consistent_protocols`, which is already tested for both gates.
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
…inate in `CZPowGate`. (quantumlib#4862)

Part of quantumlib#4858

Decompositions are tested as part of `assert_eigengate_implements_consistent_protocols`, which is already tested for both gates.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
…inate in `CZPowGate`. (quantumlib#4862)

Part of quantumlib#4858

Decompositions are tested as part of `assert_eigengate_implements_consistent_protocols`, which is already tested for both gates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants