-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kraus protocol restructured and serial concatenation implemented #4823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added serial concatanation and wrote a test for the same Fixed small error Fixed small error
Also added consistency checks for kraus with unitary and mixture Need to add serial concatenation to mixture
Kraus needs additional tests
Mixture serial concatenation pending
Need to fix tests and check
Also Added check for combinatorial explosion as requested.
With the newly proposed structure of
Possible approaches
|
Discussion from Cirq sync:
|
To complete the restructuring, #4876 must be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
size: L
250< lines changed <1000
status/stale
This has been closed due to inactivity for an extended period of time.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned #4822, the
kraus
protocol has been re-structured. The original task (#4486) has been split into two tasks to handle serial concatenation forkraus
andmixture
protocol.The serial concatenation is handled by converting the decomposed operations into their superoperator form with the help of
cirq.Moment().expand().kraus
(#4550).