Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple Qubits Clifford Gate #4791
Multiple Qubits Clifford Gate #4791
Changes from 37 commits
b2d9269
0234dda
7596136
3121748
566db2f
3dbc1c3
207a1b1
7c2f96c
5c931d1
cd948c4
4b8f3a8
e51d9a9
0058683
a157f98
66945bd
a93a874
6701aaf
b36342d
35203c1
2fcbb13
72495cb
95dfc7d
ac5659a
46fb176
5f3a62a
e6c1c63
8235795
876e966
c795cce
be25af0
bb3fa28
89d5047
c030a89
d9bc903
51933a3
f19794c
9cc461d
ed5b337
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: We should rename this to something like
MultiQubitCliffordGate
we already haveSingleQubitCliffordGate
. This could be confusing because a user might think thatCliffordGate
is a superclass ofSingleQubitCliffordGate
which it is not.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed to
MultiQubitCliffordGate
for now. But, in my opinion, it is better to haveCliffordGate
as base class and makeSingleQubitCliffordGate
as derived class in future. (Need more work, which should not be done in this PR anyway). BecauseSingleQubitCliffordGate
can reuse allCliffordGate
functions and create more functions, like related to bloch rotation, that is unique in the Single Qubit case. (And overwrite some function since in one qubit there can be more efficient implementation?) Idea 2: Alternatively, create an abstractCliffordGate
superclass and move the common methods in SingleQubit and MultipleQubit into the superclass. Wdyt?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds like a good idea to investigate in a future PR. Should we revert back to CliffordGate to make this follow up PR easier ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, as discussed in the Cirq-Cynq, will make a follow-up PR to make the SingleQubitCliffordGate as the derived class of CliffordGate. So rename it back.