Allow sourcing of dev_tools/pypath from any path #4739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable usage from zsh. Avoid changing shell variables `m`, `PREFIX`.
MichaelBroughton
approved these changes
Dec 14, 2021
MichaelBroughton
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
|
Thank you for accepting the PR. For reference here is the broken behavior in zsh that got fixed here (happened because zsh does not split unquoted scalar variables) - # OLD
$ git checkout 132005a29e
$ unset PYTHONPATH; source dev_tools/pypath
$ echo "'$PYTHONPATH'"
'/home/user/Cirq:/home/user/Cirq/cirq-aqt cirq-core cirq-google cirq-ionq cirq-pasqal cirq-rigetti cirq-web :'
# NEW
$ git checkout 876bad4f4f
$ unset PYTHONPATH; source dev_tools/pypath
$ echo "'$PYTHONPATH'"
'/home/user/Cirq:/home/user/Cirq/cirq-aqt:/home/user/Cirq/cirq-core:/home/user/Cirq/cirq-google:/home/user/Cirq/cirq-ionq:/home/user/Cirq/cirq-pasqal:/home/user/Cirq/cirq-rigetti:/home/user/Cirq/cirq-web' |
MichaelBroughton
pushed a commit
to MichaelBroughton/Cirq
that referenced
this pull request
Jan 22, 2022
Also fix its usage from zsh. Avoid changing shell variables `m`, `PREFIX`. Use `python3` instead of `python` in case the latter is not installed.
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Also fix its usage from zsh. Avoid changing shell variables `m`, `PREFIX`. Use `python3` instead of `python` in case the latter is not installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix its usage from zsh. Avoid changing shell variables
m,PREFIX.Use
python3instead ofpythonin case the latter is not installed.