Scoping for control keys #4736
Merged
Scoping for control keys #4736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use control keys in circuit construction to block controlled gates "earliest" append method from falling back to before the measurement.
| all_keys = all_keys.union(protocols.control_keys(op)) | ||
| return all_keys.difference(protocols.measurement_key_objs(self)) | ||
| controls = frozenset(k for op in self.all_operations() for k in protocols.control_keys(op)) | ||
| return controls - protocols.measurement_key_objs(self) |
There was a problem hiding this comment.
To confirm: a circuit which contains control and measurement of key "A" excludes "A" from what it returns here because "A" is internal, correct? (i.e. it's measured and used entirely within the circuit)
There was a problem hiding this comment.
Yes, the protocol returns all keys that must be defined externally before this element can be used.
95-martin-orion
approved these changes
Dec 20, 2021
95-martin-orion
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
MichaelBroughton
pushed a commit
to MichaelBroughton/Cirq
that referenced
this pull request
Jan 22, 2022
Part 12 of https://tinyurl.com/cirq-feedforward Allow for classically controlled subcircuits to be controlled by measurements done prior to that subcircuit. Such behavior "already worked" for subcircuits without repetitions. But for subcircuits with repetitions, all measurement/control keys were "lifted" to the repetition id. i.e. in a subcircuit containing control key "A", that would be lifted to "0:A" and "1:A" to distinguish them. However if the measurement 'A' is outside of the subcircuit, then that lifting would cause the control keys to no longer match the measurement key. This PR fixes the above problem by passing context data through subcircuit decomposition. The behavior is that if a control key matches a measurement key from the same subcircuit, then both are lifted to the corresponding repetition. Otherwise the control key matches to the nearest-scoped measurement key outside of the subcircuit.
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Part 12 of https://tinyurl.com/cirq-feedforward Allow for classically controlled subcircuits to be controlled by measurements done prior to that subcircuit. Such behavior "already worked" for subcircuits without repetitions. But for subcircuits with repetitions, all measurement/control keys were "lifted" to the repetition id. i.e. in a subcircuit containing control key "A", that would be lifted to "0:A" and "1:A" to distinguish them. However if the measurement 'A' is outside of the subcircuit, then that lifting would cause the control keys to no longer match the measurement key. This PR fixes the above problem by passing context data through subcircuit decomposition. The behavior is that if a control key matches a measurement key from the same subcircuit, then both are lifted to the corresponding repetition. Otherwise the control key matches to the nearest-scoped measurement key outside of the subcircuit.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Part 12 of https://tinyurl.com/cirq-feedforward Allow for classically controlled subcircuits to be controlled by measurements done prior to that subcircuit. Such behavior "already worked" for subcircuits without repetitions. But for subcircuits with repetitions, all measurement/control keys were "lifted" to the repetition id. i.e. in a subcircuit containing control key "A", that would be lifted to "0:A" and "1:A" to distinguish them. However if the measurement 'A' is outside of the subcircuit, then that lifting would cause the control keys to no longer match the measurement key. This PR fixes the above problem by passing context data through subcircuit decomposition. The behavior is that if a control key matches a measurement key from the same subcircuit, then both are lifted to the corresponding repetition. Otherwise the control key matches to the nearest-scoped measurement key outside of the subcircuit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 12 of https://tinyurl.com/cirq-feedforward
Allow for classically controlled subcircuits to be controlled by measurements done prior to that subcircuit.
Such behavior "already worked" for subcircuits without repetitions. But for subcircuits with repetitions, all measurement/control keys were "lifted" to the repetition id. i.e. in a subcircuit containing control key "A", that would be lifted to "0:A" and "1:A" to distinguish them. However if the measurement 'A' is outside of the subcircuit, then that lifting would cause the control keys to no longer match the measurement key.
This PR fixes the above problem by passing context data through subcircuit decomposition. The behavior is that if a control key matches a measurement key from the same subcircuit, then both are lifted to the corresponding repetition. Otherwise the control key matches to the nearest-scoped measurement key outside of the subcircuit.