Introduce insertion and thermal noise models #4664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95-martin-orion
requested review from
cduck,
vtomole and
a team
as code owners
|
Review is on hold for this PR - it will be split into smaller components at the request of reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #4640. It adds two noise models to Cirq:
InsertionNoiseModelinjects noise before or after certain gates based on a user-provided map.ThermalNoiseModeladds noise which simulates thermalization of a qubit - i.e. transitions from |1) to |0) or vice versa due to environmental noise.Additionally, it packages a bundle of utility objects and methods for noise generation in
noise_utils.py, notably including:OpIdentifier: a (type, qubits) tuple for matching against gates to apply noisePHYSICAL_GATE_TAG: a string tag to mark "real" gates in a circuit, so that noise models applied in sequence can identify which gates should have noise added to them.None of these changes are exposed at the top level of Cirq, as their main purpose is to support the "approximate hardware noise in Cirq" use case.