Replace the underlying representation of SingleCliffordGate by CliffordTableau #4165

BichengYing · 2021-06-05T19:11:40Z

The current implementation of SingleQubitCliffordGate is based on rotation_map and inverse_rotation_map. It is concise for SingleQubitCliffordGate but hard to extend into any number of qubits clifford gates. For generalization, this PR replaces them by the CliffordTableau. All functionalities and interfaces of SingleCliffordGate should be the same after the replacement. [WIP for #3639].

I didn't deprecate PauliTransform (#4088) in this PR for minimize the PR's responsibility. But after this PR, it will be easy to do it.

This reverts commit b2d9269.

balopat

Looking good, with nits. Do we have any idea how much slower this representation will be compared to the current mapping?

cirq-core/cirq/ops/clifford_gate.py

cirq-core/cirq/ops/clifford_gate_test.py

Co-authored-by: Balint Pato <balopat@users.noreply.github.com>

…_clifford

BichengYing · 2021-06-08T02:05:08Z

Looking good, with nits. Do we have any idea how much slower this representation will be compared to the current mapping?

Thanks for reviewing. This is just single qubit clifford gate. One more or two more dictionary lookups probably are negligible.
Plus, those extract lookup should only happen once to construct the gate. The repeated steps involve the methods like either _unitary_ or _decompose_ is untouched. This class has no _act_on_ yet. But having tableau won't slow down it.

95-martin-orion · 2021-07-01T13:39:17Z

Pinging @balopat for re-review.

…_clifford

google-cla · 2021-09-27T19:21:36Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-27T19:38:08Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-28T02:22:04Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-28T02:24:15Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

BichengYing · 2021-09-28T02:27:25Z

@ybc1991 it looks like in the time this PR has spent open, it has slipped on a few of the integration tests. Would you mind fixing those up and then we can merge this in ASAP ?

Yes, I have updated the file. I think the error was because of the serialization, which was based on the old rotation and inverse map, which won't exist as the class members after this PR. PTAL again.

MichaelBroughton · 2021-09-28T17:56:01Z

This looks good. Can you try commenting the @googlebot I fixed it to see if that can flip the switch on this CLA check ?

google-cla · 2021-09-28T17:56:38Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

BichengYing · 2021-09-28T19:14:20Z

@googlebot I fixed it.

google-cla · 2021-09-28T19:14:55Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-28T19:24:52Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

BichengYing · 2021-09-28T19:32:05Z

@googlebot I fixed it.

google-cla · 2021-09-28T19:32:46Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

…rdTableau (quantumlib#4165) The current implementation of SingleQubitCliffordGate is based on `rotation_map` and `inverse_rotation_map`. It is concise for SingleQubitCliffordGate but hard to extend into any number of qubits clifford gates. For generalization, this PR replaces them by the `CliffordTableau`. All functionalities and interfaces of SingleCliffordGate should be the same after the replacement. [WIP for quantumlib#3639]. I didn't deprecate PauliTransform (quantumlib#4088) in this PR for minimize the PR's responsibility. But after this PR, it will be easy to do it.

BichengYing added 8 commits May 15, 2021 17:22

small step to swap underlying single clifford gate to tableau [WIP}

81710b9

Merge remote-tracking branch 'upstream/master' into sq_clifford

f93a640

Merge remote-tracking branch 'upstream/master' into sq_clifford

afb2cc1

Fix the typo in clifford_gate::test_commutes_pauli

b2d9269

Revert "Fix the typo in clifford_gate::test_commutes_pauli"

0234dda

This reverts commit b2d9269.

More on switching clifford_gate by tableau representation

8a765ea

Merge remote-tracking branch 'upstream/master' into master

7596136

Merge branch 'master' into sq_clifford

ec18f71

google-cla bot added the cla: yes Makes googlebot stop complaining. label Jun 5, 2021

BichengYing added 2 commits June 5, 2021 15:13

Fix lint and coverage

30cc2ab

Format

f5cb551

BichengYing marked this pull request as ready for review June 6, 2021 01:31

BichengYing requested review from cduck, vtomole and a team as code owners June 6, 2021 01:31

BichengYing requested a review from dstrain115 June 6, 2021 01:31

balopat requested review from balopat and removed request for dstrain115 June 7, 2021 18:16

balopat suggested changes Jun 7, 2021

View reviewed changes

BichengYing and others added 6 commits June 7, 2021 18:33

Update cirq-core/cirq/ops/clifford_gate_test.py

6f404b7

Co-authored-by: Balint Pato <balopat@users.noreply.github.com>

Update cirq-core/cirq/ops/clifford_gate.py

3fd8ad0

Co-authored-by: Balint Pato <balopat@users.noreply.github.com>

Fix the clifford typo.

40251ad

Merge branch 'sq_clifford' of https://github.com/ybc1991/Cirq into sq…

02af390

…_clifford

fix from_cliiford_tableau

c144bdd

update test_from_xz_to_clifford_tableau

a4d4b71

BichengYing added 2 commits June 20, 2021 12:01

Merge remote-tracking branch 'upstream/master' into master

3121748

Merge remote-tracking branch 'upstream/master' into master

566db2f

95-martin-orion requested a review from balopat July 1, 2021 13:39

Merge branch 'sq_clifford' of https://github.com/ybc1991/Cirq into sq…

8e813b4

…_clifford

Use clifford instead of rotation map to de/serialize the gate

b98eacf

Update the json serialization with new tableau format

8c694e1

Format

ad9677a

MichaelBroughton added cla: yes Makes googlebot stop complaining. and removed cla: no labels Sep 28, 2021

Merge branch 'master' into sq_clifford

d69b3d5

google-cla bot added cla: no and removed cla: yes Makes googlebot stop complaining. labels Sep 28, 2021

MichaelBroughton added cla: yes Makes googlebot stop complaining. automerge Tells CirqBot to sync and merge this PR. (If it's running.) and removed cla: no labels Sep 28, 2021

CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Sep 28, 2021

CirqBot merged commit 34d0f8b into quantumlib:master Sep 28, 2021

CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Sep 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace the underlying representation of SingleCliffordGate by CliffordTableau #4165

Replace the underlying representation of SingleCliffordGate by CliffordTableau #4165

BichengYing commented Jun 5, 2021

balopat left a comment

BichengYing commented Jun 8, 2021

95-martin-orion commented Jul 1, 2021

google-cla bot commented Sep 27, 2021

google-cla bot commented Sep 27, 2021

google-cla bot commented Sep 28, 2021

google-cla bot commented Sep 28, 2021

BichengYing commented Sep 28, 2021

MichaelBroughton commented Sep 28, 2021

google-cla bot commented Sep 28, 2021

BichengYing commented Sep 28, 2021

google-cla bot commented Sep 28, 2021

google-cla bot commented Sep 28, 2021

BichengYing commented Sep 28, 2021

google-cla bot commented Sep 28, 2021

Replace the underlying representation of SingleCliffordGate by CliffordTableau #4165

Replace the underlying representation of SingleCliffordGate by CliffordTableau #4165

Conversation

BichengYing commented Jun 5, 2021

balopat left a comment

Choose a reason for hiding this comment

BichengYing commented Jun 8, 2021

95-martin-orion commented Jul 1, 2021

google-cla bot commented Sep 27, 2021

google-cla bot commented Sep 27, 2021

google-cla bot commented Sep 28, 2021

google-cla bot commented Sep 28, 2021

BichengYing commented Sep 28, 2021

MichaelBroughton commented Sep 28, 2021

google-cla bot commented Sep 28, 2021

BichengYing commented Sep 28, 2021

google-cla bot commented Sep 28, 2021

google-cla bot commented Sep 28, 2021

BichengYing commented Sep 28, 2021

google-cla bot commented Sep 28, 2021