Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix notebook errors from ipython upgrade #4082

Closed
wants to merge 2 commits into from
Closed

fix notebook errors from ipython upgrade #4082

wants to merge 2 commits into from

Conversation

balopat
Copy link
Contributor

@balopat balopat commented May 2, 2021

Fixes #4081.

@balopat balopat requested review from cduck, vtomole and a team as code owners May 2, 2021 07:52
@balopat balopat requested a review from tanujkhattar May 2, 2021 07:52
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label May 2, 2021
This was referenced May 2, 2021
Closed
Closed
dabacon
dabacon approved these changes May 2, 2021
View reviewed changes
Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep that fixes it, thanks @balopat

@balopat
Copy link
Contributor Author

balopat commented May 2, 2021

Closing, have been superseded by #4077!

@balopat balopat closed this May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabacon dabacon dabacon approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

@tanujkhattar tanujkhattar Awaiting requested review from tanujkhattar

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notebook test is broken at head.
2 participants
@balopat @dabacon