-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix quantum volume notebooks #3604
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!!! Can you remove the skip line from dev_tools/notebook_tests.py as well?
Here
Cirq/dev_tools/notebook_test.py
Lines 30 to 32 in 905083c
# skipping quantum volume notebooks as they have issues | |
# see https://github.com/quantumlib/Cirq/issues/3501 | |
"examples/advanced/*.ipynb", |
Done; I don't understand the test failure |
Now it's a different error.
|
Yes, agreed, to be improved. I think we should be able to output this json into a notebook that then could be previewed within github actions, or be downloadable, or even better if we can make the error more readable and colored within the log. Opened #3620.
This is exactly the kind of error the devsite pipelines caught before and were not an issue if you ran a notebook in a virtualenv with cirq installed. On the path for cirq installation (which is taken here), you'll need to run an
|
fixes #3501