Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quantum volume notebooks #3604

Merged
merged 6 commits into from
Jan 7, 2021
Merged

Conversation

mpharrigan
Copy link
Collaborator

@mpharrigan mpharrigan commented Dec 11, 2020

fixes #3501

@mpharrigan mpharrigan requested a review from balopat December 11, 2020 07:30
@mpharrigan mpharrigan requested review from cduck, vtomole and a team as code owners December 11, 2020 07:30
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Dec 11, 2020
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!!! Can you remove the skip line from dev_tools/notebook_tests.py as well?
Here

# skipping quantum volume notebooks as they have issues
# see https://github.com/quantumlib/Cirq/issues/3501
"examples/advanced/*.ipynb",

@mpharrigan
Copy link
Collaborator Author

Done; I don't understand the test failure

@mpharrigan
Copy link
Collaborator Author

Now it's a different error.

  1. The notebook test failures are impossible to read. The bash color codes don't get rendered right and the rest of it is in JSON / html
  2. Why can't it import cirq? Presumably we install that before running the notebook and/or the notebook has a pip install cell

@balopat
Copy link
Contributor

balopat commented Dec 18, 2020

Now it's a different error.

  1. The notebook test failures are impossible to read. The bash color codes don't get rendered right and the rest of it is in JSON / html

Yes, agreed, to be improved. I think we should be able to output this json into a notebook that then could be previewed within github actions, or be downloadable, or even better if we can make the error more readable and colored within the log. Opened #3620.

  1. Why can't it import cirq? Presumably we install that before running the notebook and/or the notebook has a pip install cell

This is exactly the kind of error the devsite pipelines caught before and were not an issue if you ran a notebook in a virtualenv with cirq installed. On the path for cirq installation (which is taken here), you'll need to run an import cirq before the first usage of it. Which in this case it seems like from the logs (which I agree is hard to find) is this line:

"qubits = cirq.GridQubit.rect(3,2)\n",

@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jan 7, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jan 7, 2021
@CirqBot CirqBot merged commit ae9c7bd into quantumlib:master Jan 7, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/experiments cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix quantum volume notebooks
3 participants