Drop python 3.6 support #3574
Merged
Drop python 3.6 support #3574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Do we also plan to add explicit testing for Python 3.9 soon? |
Oh yeah, it is out now since Oct 5. I'll do that in a separate PR, just to have less moving pieces in this one. Also as on 3.6 things actively break on PRs, we have some urgency here. |
95-martin-orion
approved these changes
Dec 3, 2020
|
Can also change the target for formatting: https://github.com/quantumlib/Cirq/blob/master/pyproject.toml#L3 |
balopat
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
Closed
Closed
CirqBot
pushed a commit
that referenced
this pull request
Feb 13, 2021
Reverts #3574. Rationale: we want to ensure that Cirq works on colab which is stuck at the moment at Python 3.6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop support (CI tests) for python 3.6.
Following #3347 we can safely drop python 3.6 support. This is also motivated by current breakages in Mac 3.6 and RTD #3554. This will not finalize #3347, we'll need to add some more documentation around the python support to close it fully.
Fixes #3554. See the successful build from my fork: https://readthedocs.org/projects/balopat-cirq-rtd/builds/12481463/