Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pasqal] Vendor Transformer Adoption #5130

Closed
MichaelBroughton opened this issue Mar 22, 2022 · 1 comment · Fixed by #5377
Closed

[Pasqal] Vendor Transformer Adoption #5130

MichaelBroughton opened this issue Mar 22, 2022 · 1 comment · Fixed by #5377
Assignees
@dstrain115
Labels
area/transformers kind/task A task that's part of a larger effort

Comments

@MichaelBroughton
Copy link
Collaborator

Summarize the task
With broader changes to devices (#4744) and optimizers/trasnformers (#4722), vendors might need to update device decomposition to use the newest transformer APIs. At first glance it looks like:

cirq-pasqal is rolling their own PasqalConverter optimizer which could be converted into a transformer:

Cirq/cirq-pasqal/cirq_pasqal/pasqal_device.py

Line 391 in 45624ff

class PasqalConverter(cirq.neutral_atoms.ConvertToNeutralAtomGates):

Like aqt, this calls out to the cirq-core neutral atom module. Perhaps we should consolidate this ? @HGSilveri @tanujkhattar
@MichaelBroughton MichaelBroughton added the kind/task A task that's part of a larger effort label Mar 22, 2022
@HGSilveri
Copy link
Collaborator

The PasqalConverter and ConvertToNeutralAtomGates are almost identical, so if ConvertToNeutralAtomGates is turned into a transformer, then PasqalConverter should naturally follow.

@MichaelBroughton MichaelBroughton mentioned this issue Mar 28, 2022
Closed
@dstrain115 dstrain115 self-assigned this May 11, 2022
@dstrain115 dstrain115 mentioned this issue May 19, 2022
Merged
CirqBot pushed a commit that referenced this issue May 23, 2022
@dstrain115
Change Pasqal to use transformers (#5377)
289f9ac 
- Add PasqalGateset that encapsulates gatesets
used by the PasqalDevice classes.
- Deprecate PasqalConverter and use cirq.convert_to_target_gateset
instead.

Fixes: #5130
rht pushed a commit to rht/Cirq that referenced this issue May 1, 2023
@dstrain115 @rht
Change Pasqal to use transformers (quantumlib#5377)
9bd20fa 
- Add PasqalGateset that encapsulates gatesets
used by the PasqalDevice classes.
- Deprecate PasqalConverter and use cirq.convert_to_target_gateset
instead.

Fixes: quantumlib#5130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dstrain115 dstrain115

Labels
area/transformers kind/task A task that's part of a larger effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change Pasqal to use transformers dstrain115/Cirq-1
4 participants
@MichaelBroughton @dstrain115 @HGSilveri @95-martin-orion